Skip to content

fix sharding strategy str to enum conversion #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix sharding strategy str to enum conversion #891

wants to merge 1 commit into from
+4 −1

Conversation

@IgorKasianenko
Copy link
Contributor

@IgorKasianenko IgorKasianenko commented Mar 3, 2025

What does this PR do?

Fixes #809

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@IgorKasianenko IgorKasianenko requested a review from mreso March 3, 2025 15:06
@IgorKasianenko IgorKasianenko self-assigned this Mar 3, 2025
@IgorKasianenko IgorKasianenko requested a review from init27 March 3, 2025 15:06
@IgorKasianenko
Copy link
Contributor Author

IgorKasianenko commented Mar 4, 2025 •
edited
Loading

Test fixes are in #892

@meta-cla
Copy link

meta-cla bot commented Oct 31, 2025

Hi @IgorKasianenko!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mreso mreso Awaiting requested review from mreso

@init27 init27 Awaiting requested review from init27

1 more reviewer

@riocrz riocrz riocrz approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@IgorKasianenko IgorKasianenko

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FSDP sharding_strategy parameter fails with KeyError when passed as string

3 participants

@IgorKasianenko @riocrz @facebook-github-bot